Skip to content

Demote x86_64-apple-darwin to Tier 2 with host tools #145252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Demote x86_64-apple-darwin to Tier 2 with host tools #145252

wants to merge 1 commit into from
+10 −29

Conversation

shepmaster
Copy link
Member

Switch to only using aarch64 runners (implying we are now cross-compiling) and stop running tests. In the future, we could enable (some?) tests via Rosetta 2.

@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2025

r? @jdno

rustbot has assigned @jdno.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 11, 2025
@jieyouxu jieyouxu added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 11, 2025
@shepmaster
Copy link
Member Author

@bors2 try jobs=dist-x86_64-apple

@rust-bors
Copy link

rust-bors bot commented Aug 11, 2025

⌛ Trying commit c82a9f2 with merge b05ee4d…

To cancel the try build, run the command @bors try cancel.

rust-bors bot added a commit that referenced this pull request Aug 11, 2025
@rust-bors
Auto merge of #145252 - shepmaster:demote-x86_64-apple-darwin-to-tier…
b05ee4d 
…-2, r=<try>

Demote x86_64-apple-darwin to Tier 2 with host tools

try-job: dist-x86_64-apple
@jieyouxu
Copy link
Member

Discussed beta backport during infra meeting: #t-infra > meeting 2025-08-11 @ 💬

@rustbot label: +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 11, 2025
@ehuss ehuss added the relnotes Marks issues that should be documented in the release notes of the next release. label Aug 11, 2025
@rustbot rustbot mentioned this pull request Aug 11, 2025
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Aug 11, 2025

💔 Test for b05ee4d failed: CI. Failed jobs:

@shepmaster
Demote x86_64-apple-darwin to Tier 2 with host tools
5d3595e 
Switch to only using aarch64 runners (implying we are now
cross-compiling) and stop running tests. In the future, we could
enable (some?) tests via Rosetta 2.
@shepmaster shepmaster force-pushed the demote-x86_64-apple-darwin-to-tier-2 branch from c82a9f2 to 5d3595e Compare August 11, 2025 17:37
@shepmaster
Copy link
Member Author

@bors2 try jobs=dist-x86_64-apple

rust-bors bot added a commit that referenced this pull request Aug 11, 2025
@rust-bors
Auto merge of #145252 - shepmaster:demote-x86_64-apple-darwin-to-tier…
c20c6a6 
…-2, r=<try>

Demote x86_64-apple-darwin to Tier 2 with host tools

try-job: dist-x86_64-apple
@rust-bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-apple failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
pkgbuild: Adding top-level postinstall script
pkgbuild: Wrote package to /Users/runner/work/rust/rust/build/tmp/dist/combined-tarball/pkg/miri.pkg

thread 'main' panicked at src/bootstrap/src/lib.rs:1934:25:
could not read dir "/Users/runner/work/rust/rust/build/tmp/tarball/rust/x86_64-apple-darwin/rustc-codegen-cranelift-nightly-x86_64-apple-darwin": Os { code: 2, kind: NotFound, message: "No such file or directory" }
stack backtrace:
   0: __rustc::rust_begin_unwind
             at /rustc/788da80fcfcef3f34c90def5baa32813e39a1a41/library/std/src/panicking.rs:697:5
   1: core::panicking::panic_fmt
             at /rustc/788da80fcfcef3f34c90def5baa32813e39a1a41/library/core/src/panicking.rs:75:14

@rust-bors
Copy link

rust-bors bot commented Aug 11, 2025

💔 Test for c20c6a6 failed: CI. Failed jobs:

madsmtm
madsmtm reviewed Aug 11, 2025
View reviewed changes
src/ci/github-actions/jobs.yml
@@ -537,7 +518,7 @@ auto:
NO_LLVM_ASSERTIONS: 1
NO_DEBUG_ASSERTIONS: 1
NO_OVERFLOW_CHECKS: 1
<<: *job-macos-m1
<<: *job-macos

######################
# Windows Builders #
Copy link
Contributor

@madsmtm madsmtm Aug 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if you intend for this PR to be the entire demotion? If so, then you need to edit src/doc/rustc/src/platform-support and compiler/rustc_target/src/spec/targets/x86_64_apple_darwin.rs as well (see #137869 for an example).

Otherwise, I can follow it up with a T-compiler PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I'm happy rolling all that into this PR — just wasn't aware / thought deeply about it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm left review comments

Assignees

@jdno jdno

Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shepmaster @rustbot @jieyouxu @rust-log-analyzer @madsmtm @ehuss @jdno